fix: correct permission check in watchlist sync#4310
Open
fronc wants to merge 1 commit intosct:developfrom
Open
fix: correct permission check in watchlist sync#4310fronc wants to merge 1 commit intosct:developfrom
fronc wants to merge 1 commit intosct:developfrom
Conversation
The watchlist sync permission check incorrectly uses AUTO_APPROVE_TV instead of AUTO_REQUEST_TV, causing users with only AUTO_REQUEST_TV permission to be skipped during watchlist synchronization. Fixes sct#4309
fronc
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
Contributor
|
Hi 👋🏼 This repo is no longer actively maintained. Could you please transfer this PR over to https://github.com/seerr-team/seerr? (Unless you already have as i can see you said so for another pr). We’d be happy to review it there 😄 |
Author
Yes! I believe it's already incorporated in this PR: seerr-team/seerr#2245 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a typo in
server/lib/watchlistsync.tswhere the permission check incorrectly usesAUTO_APPROVE_TVinstead ofAUTO_REQUEST_TV.The Bug
Impact
Users with only
AUTO_REQUEST_TVpermission are incorrectly skipped during watchlist sync because their TV permission isn't recognized by this check.Fix
Simple one-line change:
AUTO_APPROVE_TV→AUTO_REQUEST_TVRelated Issues
Testing
Verified that the permission check now correctly recognizes
AUTO_REQUEST_TVin the OR condition.